lkml.org 
[lkml]   [2016]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] perf, tools, stat: Implement --metric-only mode
> > @@ -1229,6 +1397,8 @@ static void print_counters(struct timespec *ts, int argc, const char **argv)
> > case AGGR_GLOBAL:
> > evlist__for_each(evsel_list, counter)
> > print_counter_aggr(counter, prefix);
> > + if (metric_only)
> > + fputc('\n', stat_config.output);
>
> this new line printing based on metric_only is all over the place..
> could we sorted out new lines in the print callbacks? this makes
> my head hurt ;-)

I don't see how a print callback could handle it. It has no idea
where the event list ends. Only the high level display function
knows that, and it prints the newlines.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.

\
 
 \ /
  Last update: 2016-03-02 17:21    [W:0.068 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site