lkml.org 
[lkml]   [2016]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063'
Date
Hi Alexandre,

On Tuesday 01 March 2016 23:17:45 kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git
> rtc-testing head: 58992ebde059d7faeab4c18bc17713c3b4c31208
> commit: 58992ebde059d7faeab4c18bc17713c3b4c31208 [55/55] rtc: pcf85063:
> remove useless century handling config: x86_64-randconfig-x012-201609
> (attached as .config)
> reproduce:
> git checkout 58992ebde059d7faeab4c18bc17713c3b4c31208
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All warnings (new ones prefixed by >>):
>
> drivers/rtc/rtc-pcf85063.c: In function 'pcf85063_get_datetime':
> >> drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063'
> >> [-Wunused-variable]
>
> struct pcf85063 *pcf85063 = i2c_get_clientdata(client);
> ^

Due to your removement of the useless century handling the last user of 'struct
pcf85063' is gone. Seems we can remove this struct entirely. What do you
think?

Regards,
Juergen

--
Pengutronix e.K.                              | Juergen Borleis             |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

\
 
 \ /
  Last update: 2016-03-02 11:22    [W:0.508 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site