Messages in this thread | | | Date | Fri, 18 Mar 2016 08:09:24 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver |
| |
On Fri, 18 Mar 2016, Lu Baolu wrote:
> Some Intel platforms have an USB port mux controlled by GPIOs. > There's a single ACPI platform device that provides both USB ID > extcon device and a USB port mux device. This MFD driver will > split the 2 devices for their respective drivers. > > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> > Suggested-by: David Cohen <david.a.cohen@linux.intel.com>
This should be at the top.
You couldn't have written the patch before it was suggested.
> Reviewed-by: Felipe Balbi <balbi@kernel.org> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
What is this sign-off meant to indicate?
> Reviewed-by: Lee Jones <lee.jones@linaro.org>
Why is this here?
a) I don't provide "Reviewed-by:" tags #alarmbells b) I have never signed this patch off
> --- > MAINTAINERS | 6 ++++
Seperate patch.
> drivers/mfd/Kconfig | 8 +++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/intel-vuport.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 89 insertions(+) > create mode 100644 drivers/mfd/intel-vuport.c
[...]
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |