Messages in this thread | | | Date | Thu, 17 Mar 2016 13:53:22 +0100 | Subject | Re: [PATCH v5 6/7][Update] cpufreq: Support for fast frequency switching | From | "Rafael J. Wysocki" <> |
| |
On Thu, Mar 17, 2016 at 12:48 PM, Juri Lelli <juri.lelli@arm.com> wrote: > On 17/03/16 12:40, Peter Zijlstra wrote: >> On Thu, Mar 17, 2016 at 11:35:07AM +0000, Juri Lelli wrote: >> >> > > + pr_warn("cpufreq: CPU%u: Fast freqnency switching not enabled\n", >> > >> > Ultra-minor nit: s/freqnency/frequency/ >> > >> > Also, is this really a warning or just a debug message? (everything >> > seems to work fine on Juno even if this is printed :-)). >> >> I would consider it a warn; this _should_ not happen. If your platform >> supports fast_switch, then you really rather want to use it. >> > > Mmm, right. So, something seems not correct here, as I get this warning > when I select schedutil on Juno (that doesn't support fast_switch).
There is a mistake here. The message should not be printed if policy->fast_switch_possible is not set.
Will fix.
| |