lkml.org 
[lkml]   [2016]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy
On Wed, Mar 16, 2016 at 07:17:51PM +0800, Harry Pan wrote:

> Conflicts:
> sound/soc/soc-dapm.c

Don't include noise like this in upstream submissions.

> + if (!strcmp(cmpnt->name, "snd-soc-dummy"))
> + return 0;
> +

This doesn't make much sense and is going to be very fragile. We
should either make the dummy component look like other components or
make the code cope with them as they stand, that way we don't have
random undocumented special cases scattered through the code. Probably
it's better to make the dummy component look like others.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-03-17 11:21    [W:0.063 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site