lkml.org 
[lkml]   [2016]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] kconfig: add unexpected data itself to warning
    Date
    If the .config parser runs into unexpected data it emits warnings like:
    .config:6911:warning: unexpected data

    Add the unexpected data itself to this warning. That makes it easier to
    discover what is actually going wrong:
    .config:6911:warning: unexpected data: CONFOG_CHARGER_TPS65217=m

    Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
    ---
    This v2 uses strcspn, as Michal suggesed. That turns a two patch series into a
    more elegant oneliner. It apparently pays off to know what string.h has to
    offer!

    scripts/kconfig/confdata.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
    index 0b7dc2fd7bac..6e22176cd6d6 100644
    --- a/scripts/kconfig/confdata.c
    +++ b/scripts/kconfig/confdata.c
    @@ -377,7 +377,9 @@ load:
    continue;
    } else {
    if (line[0] != '\r' && line[0] != '\n')
    - conf_warning("unexpected data");
    + conf_warning("unexpected data: %.*s",
    + (int)strcspn(line, "\r\n"), line);
    +
    continue;
    }
    setsym:
    --
    2.4.3
    \
     
     \ /
      Last update: 2016-03-16 22:01    [W:5.132 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site