Messages in this thread | | | Date | Tue, 15 Mar 2016 16:13:22 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH v2] drivers/firmware/broadcom/bcm47xx_nvram.c: fix incorrect __ioread32_copy |
| |
On 03/16, Aaro Koskinen wrote: > Commit 1f330c327900 ("drivers/firmware/broadcom/bcm47xx_nvram.c: use > __ioread32_copy() instead of open-coding") switched to use a generic copy > function, but failed to notice that the header pointer is updated between > the two copies, resulting in bogus data being copied in the latter one. > Fix by keeping the old header pointer. > > The patch fixes totally broken networking on WRT54GL router (both LAN > and WLAN interfaces fail to probe). > > Fixes: 1f330c327900 ("drivers/firmware/broadcom/bcm47xx_nvram.c: use __ioread32_copy() instead of open-coding") > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |