lkml.org 
[lkml]   [2016]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v3,1/8] powerpc: Create a helper for getting the kernel toc value
On Mon, 14 Mar 2016, Michael Ellerman wrote:

> > Move the logic to work out the kernel toc pointer into a header. This is
> > a good cleanup, and also means we can use it elsewhere in future.
> >
> > Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> > Reviewed-by: Torsten Duwe <duwe@suse.de>
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>
> Series applied to powerpc next.
>
> https://git.kernel.org/powerpc/c/a5cab83cd3d2d75d3893276cb5

Thanks Michael; this is an excellent basis for ppc live patching, but FYI
I am not merging that one to my tree just yet.

The solution (*) for functions with non-trivial argument list is not there
yet, and it's my requirement for this to be taken care of in a way that's
not prone to easily-done human errors on the patch-producer side.

(*) both "making it work" or "making it so broken that it's guaranteed
that noone would ever produce a patch that brings the kernel down" is
okay, but I really don't feel that just documenting the limitation is
sufficient and safe in this case; kudos to Torsten here for
idenfitfying the problem before it actually became The Problem

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2016-03-15 03:01    [W:0.131 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site