lkml.org 
[lkml]   [2016]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 17/50] ncpfs: fix a braino in OOM handling in ncp_fill_cache()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Al Viro <viro@zeniv.linux.org.uk>

    commit 803c00123a8012b3a283c0530910653973ef6d8f upstream.

    Failing to allocate an inode for child means that cache for *parent* is
    incompletely populated. So it's parent directory inode ('dir') that
    needs NCPI_DIR_CACHE flag removed, *not* the child inode ('inode', which
    is what we'd failed to allocate in the first place).

    Fucked-up-in: commit 5e993e25 ("ncpfs: get rid of d_validate() nonsense")
    Fucked-up-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ncpfs/dir.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ncpfs/dir.c
    +++ b/fs/ncpfs/dir.c
    @@ -633,7 +633,7 @@ ncp_fill_cache(struct file *file, struct
    d_rehash(newdent);
    } else {
    spin_lock(&dentry->d_lock);
    - NCP_FINFO(inode)->flags &= ~NCPI_DIR_CACHE;
    + NCP_FINFO(dir)->flags &= ~NCPI_DIR_CACHE;
    spin_unlock(&dentry->d_lock);
    }
    } else {

    \
     
     \ /
      Last update: 2016-03-14 19:41    [W:4.146 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site