lkml.org 
[lkml]   [2016]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v19 04/23] vfs: Make the inode passed to inode_change_ok non-const
    Date
    We will need to call iop->permission and iop->get_acl from
    inode_change_ok() for additional permission checks, and both take a
    non-const inode.

    Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
    Reviewed-by: J. Bruce Fields <bfields@redhat.com>
    Reviewed-by: Andreas Dilger <adilger@dilger.ca>
    ---
    fs/attr.c | 2 +-
    include/linux/fs.h | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/attr.c b/fs/attr.c
    index 25b24d0..7ca7fa0 100644
    --- a/fs/attr.c
    +++ b/fs/attr.c
    @@ -28,7 +28,7 @@
    * Should be called as the first thing in ->setattr implementations,
    * possibly after taking additional locks.
    */
    -int inode_change_ok(const struct inode *inode, struct iattr *attr)
    +int inode_change_ok(struct inode *inode, struct iattr *attr)
    {
    unsigned int ia_valid = attr->ia_valid;

    diff --git a/include/linux/fs.h b/include/linux/fs.h
    index 97e34ba..efff04f 100644
    --- a/include/linux/fs.h
    +++ b/include/linux/fs.h
    @@ -2908,7 +2908,7 @@ extern int buffer_migrate_page(struct address_space *,
    #define buffer_migrate_page NULL
    #endif

    -extern int inode_change_ok(const struct inode *, struct iattr *);
    +extern int inode_change_ok(struct inode *, struct iattr *);
    extern int inode_newsize_ok(const struct inode *, loff_t offset);
    extern void setattr_copy(struct inode *inode, const struct iattr *attr);

    --
    2.5.0
    \
     
     \ /
      Last update: 2016-03-14 16:41    [W:2.484 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site