lkml.org 
[lkml]   [2016]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC
From
Date


On 14/03/2016 10:41, Suravee Suthikulpanit wrote:
>>>>>>
>>>>>> + kvm_lapic_set_vector(vec, avic_get_bk_page_entry(svm,
>>>>>> APIC_IRR));
>>>>
>>>> (I think that smp_mb here would make sense, even though we're fine now
>>>> thanks to re-checking vcpu->mode in kvm_vcpu_kick.
>>>
>>> Right, though only a smp_mb__after_atomic() is required (which is a
>>> compiler barrier). It is similarly required in vmx.
>>
>> True, kvm_lapic_set_vector uses a lock prefix.
>>
>> (I thought it behaves like atomic_set, which would require MFENCE for
>> correct ordering here ... I don't like smp_mb__after_atomic much
>> because of the discrepancy on some atomic operations.)
>>
>
> So, should i just use smb_mb() in this case?

You should use smp_mb__after_atomic().

Paolo

\
 
 \ /
  Last update: 2016-03-14 14:01    [W:0.168 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site