Messages in this thread | | | Date | Mon, 14 Mar 2016 11:52:08 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support |
| |
Hi,
On Sat, Mar 12, 2016 at 12:48:02PM +0800, Vishnu Patekar wrote: > Hello Linus, > > > On Wed, Mar 9, 2016 at 10:55 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Sat, Mar 5, 2016 at 10:42 PM, Vishnu Patekar > > <vishnupatekar0510@gmail.com> wrote: > > > >> The A83T has R_PIO pin controller, it's same as A23, execpt A83T > >> interrupt bit is 6th and A83T has one extra pin PL12. > >> > >> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com> > >> Acked-by: Chen-Yu Tsai <wens@csie.org> > >> Acked-by: Rob Herring <robh@kernel.org> > > > > As partly noted by others: > > > >> +config PINCTRL_SUN8I_A83T_R > >> + def_bool MACH_SUN8I > > > > bool > > > >> + depends on RESET_CONTROLLER > > > > Should it rather select RESET_CONTROLLER? > I used depends on and def_bool as it is used for other sunxi pinctrl drivers. > Using bool and select will not harm anything.
It will, at least in the case of def_bool, since that symbol will not be enabled by default, and you'll have no way to enable it.
And RESET_CONTROLLER is a bit messy, since you can't just select it because it also has a dependency on an ARCH_HAS_RESET_CONTROLLER symbol.
> Should I change it to bool and select ? or keep it to be uniform with > earlier options?
Please keep it that way.
Thanks, Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |