Messages in this thread | | | Date | Fri, 11 Mar 2016 13:21:46 -0800 | Subject | Re: [PATCH v10 01/59] PCI: Add pci_find_root_bus_resource() | From | Yinghai Lu <> |
| |
Hi Bjorn,
Thanks for taking time to look at those patches!
On Wed, Mar 9, 2016 at 7:54 PM, Bjorn Helgaas <helgaas@kernel.org> wrote: > On Wed, Feb 24, 2016 at 06:11:52PM -0800, Yinghai Lu wrote: >> Add pci_find_root_bus_resource() to return root bus resource >> for input resource. >> >> For sparc mem64 support, We need that host bridge window res: >> 1. we need direct parent for request_resource_conflict() calling in >> pci_register_legacy_regions(). >> 2. check if return is NULL to decide if region is valid or not. > > Whenever somebody proposes a new interface that's only required for > one architecture, the obvious question is "what is unique about that > architecture that makes the new interface necessary?"
Good point.
I was thinking to keep the current behavior in sparc64 arch, as I don't want to break old setups.
Later we can try to make it more like arch.
> > Neither this patch nor the follow-on patch that adds the use of > pci_find_root_bus_resource() answers that question. >
would be better to keep those two in same patch?
Thanks
Yinghai
| |