Messages in this thread | | | Subject | Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART | From | Peter Hurley <> | Date | Fri, 11 Mar 2016 07:02:14 -0800 |
| |
Hi Christopher,
On 03/10/2016 10:35 PM, Christopher Covington wrote: > Version 2 of the Server Base System Architecture (SBSAv2) describes the > Generic UART registers as 32 bits wide. At least one implementation, found > on the Qualcomm Technologies QDF2432, only supports 32 bit accesses. > SBSAv3, which describes supported access sizes in greater detail, > explicitly requires support for both 16 and 32 bit accesses to all > registers (and 8 bit accesses to some but not all). Therefore, for broad > compatibility, simply use 32 bit accessors for the SBSA UART.
So this eliminates the need to configure SBSA port via ACPI, correct? Thus, Aleksey can drop his "serial: pl011: use SPCR to setup 32-bit access"?
> Tested-by: Mark Langsdorf <mlangsdo@redhat.com> > Signed-off-by: Christopher Covington <cov@codeaurora.org> > --- > Changes new in v2: > * Fixed from address > * Elaborated on forward (SBSAv3) compatibility in commit message > * Included Mark Langsdorf's Tested-by, which now covers: > QDF2432 > Seattle > X-Gene 1 > --- > drivers/tty/serial/amba-pl011.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > index c0da0cc..ffb5eb8 100644 > --- a/drivers/tty/serial/amba-pl011.c > +++ b/drivers/tty/serial/amba-pl011.c > @@ -121,6 +121,7 @@ static struct vendor_data vendor_arm = { > > static struct vendor_data vendor_sbsa = { > .reg_offset = pl011_std_offsets, > + .access_32b = true, > .oversampling = false, > .dma_threshold = false, > .cts_event_workaround = false, >
| |