lkml.org 
[lkml]   [2016]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/18] mm: make vm_mmap killable
    On Fri 11-03-16 10:59:30, Vlastimil Babka wrote:
    > On 02/29/2016 02:26 PM, Michal Hocko wrote:
    > >From: Michal Hocko <mhocko@suse.com>
    > >
    > >All the callers of vm_mmap seem to check for the failure already
    > >and bail out in one way or another on the error which means that
    >
    > Hmm I'm not that sure about this one:
    > 17 1071 fs/binfmt_elf.c <<load_elf_binary>>
    >
    > Assigns result of vm_mmap() to "error" variable which is never checked.

    Yes it is not checked but not used either. If the current got killed
    then it wouldn't return to the userspace so my understanding is that not
    checking this value is not a problem. At least that is my understanding.

    > Shouldn't __must_check trigger here?

    well, __must_check is a misleading name. It doesn't actually enforce the
    value is checked. It just has to be used and an assignment is
    sufficient. I was discussing this without our gcc guy and he promissed
    to look and try to come up with a different attribute which would
    actually work like __must_check.

    --
    Michal Hocko
    SUSE Labs

    \
     
     \ /
      Last update: 2016-03-11 13:41    [W:3.990 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site