lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 115/130] hwmon: (ads1015) Handle negative conversion values correctly
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Peter Rosin <peda@axentia.se>

    commit acc146943957d7418a6846f06e029b2c5e87e0d5 upstream.

    Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
    dividends when the divisor is unsigned.

    Signed-off-by: Peter Rosin <peda@axentia.se>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hwmon/ads1015.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hwmon/ads1015.c
    +++ b/drivers/hwmon/ads1015.c
    @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_
    struct ads1015_data *data = i2c_get_clientdata(client);
    unsigned int pga = data->channel_data[channel].pga;
    int fullscale = fullscale_table[pga];
    - const unsigned mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
    + const int mask = data->id == ads1115 ? 0x7fff : 0x7ff0;

    return DIV_ROUND_CLOSEST(reg * fullscale, mask);
    }
    \
     
     \ /
      Last update: 2016-03-02 01:21    [W:4.423 / U:0.752 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site