lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] serial: flush ldisc after hangup
From
Date
On 03/01/2016 02:01 PM, Peter Hurley wrote:
> On 03/01/2016 10:21 AM, Josef Bacik wrote:
>> On 03/01/2016 01:17 PM, Peter Hurley wrote:
>
>>> Yeah, the race is that the ldisc should not be attempting i/o to
>>> the driver at all. This problem is fixed in -next already, but in
>>> the tty core rather than in each individual tty driver.
>>>
>>
>> Great! Which patch/patches fix this? I looked at linux-next and
>> there's a lot of refactoring stuff, do I need all the things or is
>> there a specific one that fixes this problem? Thanks,
>
> The series that fixes this design problem introduce in 3.10 are these
> patches:
>
> staging: digi: Replace open-coded tty_wakeup()
> serial: 68328: Remove bogus ldisc reset
> bluetooth: hci_ldisc: Remove dead code
> NFC: nci: Remove dead code
> tty: Remove chars_in_buffer() line discipline method
> tty: Fix unsafe ldisc reference via ioctl(TIOCGETD)
> n_tty: Fix unsafe reference to "other" ldisc
> tty: Reset c_line from driver's init_termios
> staging/speakup: Use tty_ldisc_ref() for paste kworker
> tty: Fix comments for tty_ldisc_get()
> tty: Fix comments for tty_ldisc_release()
> tty: Prepare for destroying line discipline on hangup
> tty: Handle NULL tty->ldisc
> tty: Move tty_ldisc_kill()
> tty: Use 'disc' for line discipline index name
> tty: Refactor tty_ldisc_reinit() for reuse
> tty: Destroy ldisc instance on hangup
>
> 'tty: Fix unsafe ldisc reference via ioctl(TIOCGETD)' and
> 'tty: Fix unsafe reference to "other" ldisc' have already
> made their way to most stable trees, afaict.
>
> I doubt I'll submit any more of this series for stable;
> it's just too invasive. I'll probably do it per-driver, like
> your patch. Just an fyi.
>

That's fine, we aren't afraid to pull back lots of stuff to our kernels,
as long as they are destined for upstream. Thanks for the help!

Josef

\
 
 \ /
  Last update: 2016-03-01 20:41    [W:0.082 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site