Messages in this thread | | | Date | Tue, 01 Mar 2016 13:23:33 +0000 | From | Luis de Bethencourt <> | Subject | Re: [PATCH] xfs: remove impossible condition |
| |
On 01/03/16 12:08, Christoph Hellwig wrote: > On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote: >> bp_release is set to 0 just before the breakpoint of the for loop before >> the conditional check (in line 458). The other breakpoint is a goto that >> skips the dead code. > > Yes, this looks correct: > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > The whole code around this is rather grotty and could use some more > work, though.. >
Thanks for the review Christoph!
If you have some specific things in mind that I could fix in the code around this, I am happy to add it to my ToDo list. Or I can continue reading it and let you know of anything I see, so you can confirm before I try to fix it.
Regards, Luis
| |