Messages in this thread | | | Date | Tue, 1 Mar 2016 14:06:37 +0100 | From | Alexandre Belloni <> | Subject | Re: [PATCH] rtc: rtc-generic: use correct header file |
| |
On 01/03/2016 at 18:16:40 +0530, Sudip Mukherjee wrote : > The allmodconfig build of m32r fails with errors like: > > In file included from drivers/rtc/rtc-generic.c:12:0: > arch/m32r/include/asm/rtc.h:46:8: error: redefinition of 'struct rtc_time' > > drivers/rtc/rtc-generic.c: In function 'generic_get_time': > drivers/rtc/rtc-generic.c:16:21: error: implicit declaration of function 'get_rtc_time' > > drivers/rtc/rtc-generic.c:18:12: error: 'RTC_BATT_BAD' undeclared > > drivers/rtc/rtc-generic.c: In function 'generic_set_time': > drivers/rtc/rtc-generic.c:26:6: error: implicit declaration of function 'set_rtc_time' > > Apart from m32r, many other arch like xtensa, sparc are failing with: > drivers/rtc/rtc-generic.c:12:21: fatal error: asm/rtc.h: No such file or directory > > Other rtc drivers are using asm-generic/rtc.h, so use it here. > > Fixes: 2a32c792f1c9 ("rtc: enable COMPILE_TEST") > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > --- > > m32r allmodconfig build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/112780210 > > failure with sparc and xtensa needs more work as after this patch also > they fail with error about missing file "mc146818rtc.h". >
Yeah I'll remove COMPILE_TEST for that driver.
-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |