lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 044/342] rtnl: RTM_GETNETCONF: fix wrong return value
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Anton Protopopov <a.s.protopopov@gmail.com>

    [ Upstream commit a97eb33ff225f34a8124774b3373fd244f0e83ce ]

    An error response from a RTM_GETNETCONF request can return the positive
    error value EINVAL in the struct nlmsgerr that can mislead userspace.

    Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
    Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/devinet.c | 2 +-
    net/ipv6/addrconf.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/net/ipv4/devinet.c
    +++ b/net/ipv4/devinet.c
    @@ -1847,7 +1847,7 @@ static int inet_netconf_get_devconf(stru
    if (err < 0)
    goto errout;

    - err = EINVAL;
    + err = -EINVAL;
    if (!tb[NETCONFA_IFINDEX])
    goto errout;

    --- a/net/ipv6/addrconf.c
    +++ b/net/ipv6/addrconf.c
    @@ -583,7 +583,7 @@ static int inet6_netconf_get_devconf(str
    if (err < 0)
    goto errout;

    - err = EINVAL;
    + err = -EINVAL;
    if (!tb[NETCONFA_IFINDEX])
    goto errout;
    \
     
     \ /
      Last update: 2016-03-02 03:21    [W:4.203 / U:1.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site