Messages in this thread | | | Date | Tue, 1 Mar 2016 15:55:33 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH] clk: ti: Fix some errors found by static checkers |
| |
* Stephen Boyd <sboyd@codeaurora.org> [160301 10:55]: > drivers/clk/ti/clk-814x.c:34:12: warning: symbol 'dm814x_adpll_early_init' was not declared. Should it be static? > drivers/clk/ti/clk-814x.c:58:12: warning: symbol 'dm814x_adpll_enable_init_clocks' was not declared. Should it be static? > drivers/clk/ti/adpll.c:465 ti_adpll_recalc_rate() warn: should '__readw(d->regs + 20) << 18' be a 64 bit type? > drivers/clk/ti/adpll.c:945 ti_adpll_probe() error: we previously assumed 'd->clocks' could be null (see line 921) > > The last one looks like a real bug because we don't return an > error on allocation failure.
Yeah nice, that's a real bug:
Tested-by: Tony Lindgren <tony@atomide.com>
| |