lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/5] net: sxgbe: fix error paths in sxgbe_platform_probe()
    Date
    We need to use post-decrement to ensure that irq_dispose_mapping is
    also called on priv->rxq[0]->irq_no; moreover, if one of the above for
    loops failed already at i==0 (so we reach one of these labels with
    that value of i), we'll enter an essentially infinite loop of
    out-of-bounds accesses.

    Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    ---
    drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
    index b02eed12bfc5..73427e29df2a 100644
    --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
    +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
    @@ -155,11 +155,11 @@ static int sxgbe_platform_probe(struct platform_device *pdev)
    return 0;

    err_rx_irq_unmap:
    - while (--i)
    + while (i--)
    irq_dispose_mapping(priv->rxq[i]->irq_no);
    i = SXGBE_TX_QUEUES;
    err_tx_irq_unmap:
    - while (--i)
    + while (i--)
    irq_dispose_mapping(priv->txq[i]->irq_no);
    irq_dispose_mapping(priv->irq);
    err_drv_remove:
    --
    2.1.4
    \
     
     \ /
      Last update: 2016-02-09 21:21    [W:3.196 / U:0.756 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site