lkml.org 
[lkml]   [2016]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally

On Saturday 06 February 2016 08:07 PM, Laxman Dewangan wrote:
> - ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL,
> - max77686_rtc_alarm_irq, 0,
> - "rtc-alarm1", info);
> - if (ret < 0)
> + ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
> + "rtc-alarm1", info);
> + if (ret < 0) {
> dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
> info->virq, ret);
> + goto err_rtc;
> + }
> +
> + return 0;
>
> err_rtc:

Oops.. I wish I should have called regmap_irq_put_virq(info->virq); here.

Please let me know if I can respin this patch only instead of entire series.


\
 
 \ /
  Last update: 2016-02-08 12:01    [W:0.119 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site