lkml.org 
[lkml]   [2016]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource
Date
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:

>> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse
>
> Fixes: tag here?
Heuh no. It doesn't fix this commit, it uses a feature brought by this commit.

>> + if (irq_get_trigger_type(dev->irq) == IRQF_TRIGGER_NONE)
>> dev_warn(db->dev, "WARNING: no IRQ resource flags set.\n");
>>
>> irqflags |= IRQF_SHARED;
>
> Why not just initialize to IRQF_SHARED?
> But actually you don't need this variable anymore.
Yeah, makes sense.

Cheers.

--
Robert

\
 
 \ /
  Last update: 2016-02-07 13:01    [W:0.085 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site