lkml.org 
[lkml]   [2016]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure
From
Date
On 2016-02-04 18:09, Ard Biesheuvel wrote:
> - ${NM} -n ${1} | \
> - scripts/kallsyms ${kallsymopt} | \
> - ${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -
> + # capture the return code of scripts/kallsyms in $RC
> + local RC=`(${NM} -n ${1} | \
> + (scripts/kallsyms ${kallsymopt}; echo $? 1>&3) | \
> + ${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -) 3>&1`
> +
> + [ $RC -eq 0 ]

This now ignores errors by the assembler (and makes the function hard to
read). Please change it to use a temporary file.

Michal

\
 
 \ /
  Last update: 2016-02-05 11:21    [W:2.170 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site