lkml.org 
[lkml]   [2016]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support
From
On Fri, Feb 5, 2016 at 11:02 PM, Lucas De Marchi
<lucas.de.marchi@gmail.com> wrote:
> Hi Daniel,
>
> On Fri, Feb 5, 2016 at 11:17 AM, Daniel Baluta <daniel.baluta@intel.com> wrote:
>> +
>> +static const struct i2c_device_id ads1015_id[] = {
>> + {"ads1015", 0},
>> + {}
>> +};
>
> Since this module is not 100% compatible with the hwmon version,
> wouldn't it be better to use another id?

Hmm, as it is now it should be 100% compatible with the hwmon driver
for ads1015 device.

I don't have a strong preference for id here. Do you see any problems using
this id?

>
> Other than that, I tested it on the MinnowBoard Max with a Drone Lure
> connected and it works fine.

thanks,
Daniel.

\
 
 \ /
  Last update: 2016-02-05 23:01    [W:0.179 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site