lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support
From
Date
fu.wei@linaro.org wrote:
> +#ifdef CONFIG_ARM_SBSA_WATCHDOG_PANIC
> +static bool panic_enabled = true;

I think this should default to 'false', because IMHO, this seems like an
odd feature. I'm not crazy about the fact that there's a Kconfig option
for it either, but I'm not going to NACK this patch.

I personally would prefer to drop this patch, and just wait for
full-blown pre-timeout support. It feels like a debugging feature that
doesn't really belong upstream. But like I said, it's just my opinion,
and I won't complain if I'm outvoted.

\
 
 \ /
  Last update: 2016-02-03 19:01    [W:0.117 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site