lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/workingset: do not forget to unlock page
On Wed, Feb 03, 2016 at 01:19:39PM -0800, Andrew Morton wrote:
> Yup. I turned it into a fix against
> mm-workingset-per-cgroup-cache-thrash-detection.patch, which is where
> the bug was added. And I did the goto thing instead, so the final
> result will be
>
> void workingset_activation(struct page *page)
> {
> struct lruvec *lruvec;
>
> lock_page_memcg(page);
> /*
> * Filter non-memcg pages here, e.g. unmap can call
> * mark_page_accessed() on VDSO pages.
> *
> * XXX: See workingset_refault() - this should return
> * root_mem_cgroup even for !CONFIG_MEMCG.
> */
> if (!mem_cgroup_disabled() && !page_memcg(page))
> goto out;
> lruvec = mem_cgroup_zone_lruvec(page_zone(page), page_memcg(page));
> atomic_long_inc(&lruvec->inactive_age);
> out:
> unlock_page_memcg(page);
> }

LGTM, thank you.

\
 
 \ /
  Last update: 2016-02-03 23:41    [W:0.057 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site