Messages in this thread Patch in this message | | | Date | Sun, 28 Feb 2016 07:52:37 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v18 0/9] Compile-time stack metadata validation |
| |
FYI, I got this build failure on allmodconfig-x86-64:
objtool.c:134:1: error: control reaches end of non-void function [-Werror=return-type]
that was with:
gcc version 4.8.3 20140911 (Red Hat 4.8.3-7) (GCC)
GCC 5.2.1 does not trigger this warning, which is I suspect why you have not seen this in your own testing.
I applied the fix below: all paths that generate a nonzero error do an explicit exit(), so return 0 is fine here.
Thanks,
Ingo
=====================>
tools/objtool/objtool.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c index 4e53d272c0c3..46c326db4f46 100644 --- a/tools/objtool/objtool.c +++ b/tools/objtool/objtool.c @@ -131,4 +131,6 @@ int main(int argc, const char **argv) cmd_usage(); handle_internal_command(argc, argv); + + return 0; }
| |