lkml.org 
[lkml]   [2016]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] bsp: add SoC device to brcmstb
Date
On Friday 26 February 2016 10:36:27 Florian Fainelli wrote:
> On 26/02/16 05:58, Arnd Bergmann wrote:
> > On Thursday 25 February 2016 16:19:07 Justin Chen wrote:
> >> */
> >> void brcmstb_biuctrl_init(void);
> >>
> >> +/*
> >> + * Helper functions for getting family or product id from the
> >> + * SoC driver.
> >> + */
> >> +u32 brcmstb_get_family_id(void);
> >> +u32 brcmstb_get_product_id(void);
> >> +
> >> #endif /* __BRCMSTB_SOC_H */
> >> --
> >
> > Please remove the declarations from the header file and make the
> > variable local to this file, to make sure no other driver accidentally
> > accesses them.
>
> I would remove these two helper functions completely, we do not need
> them right now in an upstream kernel, if we ever need them, we could add
> them back, but we have no use for these two now.

Ok, that sounds even better.

Arnd

\
 
 \ /
  Last update: 2016-02-26 22:21    [W:2.410 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site