lkml.org 
[lkml]   [2016]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] pinctrl: sh-pfc: r8a7795: Add CAN support
From
Hi Ramesh,

On Fri, Feb 26, 2016 at 12:10 PM, Ramesh Shanmugasundaram
<ramesh.shanmugasundaram@bp.renesas.com> wrote:
> This patch adds CAN[0-1] pinmux support to r8a7795 SoC.
>
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>

Thanks for the update!

> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> @@ -1535,6 +1535,38 @@ static const unsigned int audio_clkout3_b_mux[] = {
> AUDIO_CLKOUT3_B_MARK,
> };
>
> +/* - CAN ------------------------------------------------------------------ */
> +static const unsigned int can0_data_a_pins[] = {
> + /* TX, RX */
> + RCAR_GP_PIN(1, 23), RCAR_GP_PIN(1, 24),
> +};

[...]

> +static const unsigned int can_clk_mux[] = {
> + CAN_CLK_MARK,
> +};
> +
> /* - EtherAVB --------------------------------------------------------------- */
> static const unsigned int avb_link_pins[] = {
> /* AVB_LINK */

However, "can" should be below "avb".

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2016-02-26 14:01    [W:0.061 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site