lkml.org 
[lkml]   [2016]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] f2fs: update inode page under cp_rwsem lock
Date
We should update inode page under protection of cp_rwsem lock, otherwise
new dirty inode pages will generated by ->fsync or ->write_inode during
checkpoint, which should not be allowed.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
---
fs/f2fs/inode.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index cb269c4..cdfe114 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -295,6 +295,7 @@ retry:
int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc)
{
struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
+ bool updated;

if (inode->i_ino == F2FS_NODE_INO(sbi) ||
inode->i_ino == F2FS_META_INO(sbi))
@@ -307,7 +308,11 @@ int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc)
* We need to balance fs here to prevent from producing dirty node pages
* during the urgent cleaning time when runing out of free sections.
*/
- if (update_inode_page(inode))
+ f2fs_lock_op(sbi);
+ updated = update_inode_page(inode);
+ f2fs_unlock_op(sbi);
+
+ if (updated)
f2fs_balance_fs(sbi, true);
return 0;
}
--
2.7.0

\
 
 \ /
  Last update: 2016-02-25 11:21    [W:0.044 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site