lkml.org 
[lkml]   [2016]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
    On Thu, Feb 25, 2016 at 06:26:31AM +0800, chengang@emindsoft.com.cn wrote:
    > From: Chen Gang <chengang@emindsoft.com.cn>
    >
    > Always notice about 80 columns, and the white space near '|'.
    >
    > Let the wrapped function parameters align as the same styles.
    >
    > Remove redundant statement "enum zone_type z;" in function gfp_zone.
    >
    > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

    NAK from me at least. From my perspective, it's preferrable to preserve
    blame than go through a layer of cleanup when looking for the commit
    that defined particular flags. It's ok to cleanup code at the same time
    definitions change for functional or performance reasons.

    --
    Mel Gorman
    SUSE Labs

    \
     
     \ /
      Last update: 2016-02-25 11:01    [W:2.258 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site