lkml.org 
[lkml]   [2016]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] x86/mbm: Intel Memory B/W Monitoring enumeration and init
On Wed, 24 Feb 2016, Vikas Shivappa wrote:
> On Wed, 24 Feb 2016, Thomas Gleixner wrote:
> > You really should register the notifier _AFTER_ registering the pmu. That
> > needs to be fixed anyway, because the existing code leaks the notifier AND
> > memory in case perf_pmu_register fails.
>
> Correct, Will fix the notifier leak

It's not only a notifier leak. The existing code also leaks memory. Please fix
that before adding the new stuff in a seperate patch.

Thanks,

tglx

\
 
 \ /
  Last update: 2016-02-24 21:01    [W:0.077 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site