Messages in this thread | | | Subject | Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address | From | Aravind Gopalakrishnan <> | Date | Wed, 24 Feb 2016 12:02:49 -0600 |
| |
On 2/24/2016 5:33 AM, Borislav Petkov wrote: > On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote: >> I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well. >> So might be better to retain it here. > Actually, I'm thinking, these all are - even if used in multiple files > - all MCE-specific and therefore used in MCE/RAS-specific code. So they > all should go into mce.h. Everything RAS includes that header so they're > perfectly fine there...
Hmm. We introduced MSR_AMD64_SMCA_MCx_CONFIG in this patch- https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e6c8f1873be8a14c7e44202df1f7e6ea61bf3352
Should I change that as well and move it to mce.h?
>> (It comes up to 81 chars, but will ignore checkpatch in this case..) > The 80-cols rule is not a hard one. Here's some food for thought: > > https://lkml.kernel.org/r/20160219095132.GA9681@gmail.com >
Got it.
Thanks, -Aravind.
| |