lkml.org 
[lkml]   [2016]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 005/142] remoteproc: avoid stack overflow in debugfs file
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 92792e48e2ae6051af30468a87994b5432da2f06 upstream.

    Recent gcc versions warn about reading from a negative offset of
    an on-stack array:

    drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
    drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]

    I don't see anything in sys_write() that prevents us from
    being called with a zero 'count' argument, so we should
    add an extra check in rproc_recovery_write() to prevent the
    access and avoid the warning.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Fixes: 2e37abb89a2e ("remoteproc: create a 'recovery' debugfs entry")
    Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/remoteproc/remoteproc_debugfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
    index 9d30809bb407..916af5096f57 100644
    --- a/drivers/remoteproc/remoteproc_debugfs.c
    +++ b/drivers/remoteproc/remoteproc_debugfs.c
    @@ -156,7 +156,7 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
    char buf[10];
    int ret;

    - if (count > sizeof(buf))
    + if (count < 1 || count > sizeof(buf))
    return count;

    ret = copy_from_user(buf, user_buf, count);
    --
    2.7.1
    \
     
     \ /
      Last update: 2016-02-24 12:41    [W:4.041 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site