| From | Jiri Slaby <> | Subject | [PATCH 3.12 029/142] ALSA: usb-audio: avoid freeing umidi object twice | Date | Wed, 24 Feb 2016 11:03:44 +0100 |
| |
From: Andrey Konovalov <andreyknvl@gmail.com>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit 07d86ca93db7e5cdf4743564d98292042ec21af7 upstream.
The 'umidi' object will be free'd on the error path by snd_usbmidi_free() when tearing down the rawmidi interface. So we shouldn't try to free it in snd_usbmidi_create() after having registered the rawmidi interface.
Found by KASAN.
Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com> Acked-by: Clemens Ladisch <clemens@ladisch.de> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- sound/usb/midi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/usb/midi.c b/sound/usb/midi.c index 9123fc518f07..424c1e874bd3 100644 --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -2365,7 +2365,6 @@ int snd_usbmidi_create(struct snd_card *card, else err = snd_usbmidi_create_endpoints(umidi, endpoints); if (err < 0) { - snd_usbmidi_free(umidi); return err; } -- 2.7.1
|