lkml.org 
[lkml]   [2016]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/27] mm, vmscan: Begin reclaiming pages on a per-node basis
On Tue, Feb 23, 2016 at 10:57:22AM -0800, Johannes Weiner wrote:
> On Tue, Feb 23, 2016 at 03:04:29PM +0000, Mel Gorman wrote:
> > @@ -2428,10 +2448,11 @@ static bool shrink_zone(struct zone *zone, struct scan_control *sc,
> > reclaimed = sc->nr_reclaimed;
> > scanned = sc->nr_scanned;
> >
> > + sc->reclaim_idx = reclaim_idx;
> > shrink_zone_memcg(zone, memcg, sc, &lru_pages);
> > zone_lru_pages += lru_pages;
>
> The setting of sc->reclaim_idx is unexpected here. Why not set it in
> the caller and eliminate the reclaim_idx parameter?
>

Initially because it was easier to develop the patch for but it's good
either way. I updated this patch and handled the conflicts. It's now set
in the callers.

Thanks.

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2016-02-24 12:01    [W:3.347 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site