lkml.org 
[lkml]   [2016]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v10 33/59] PCI: Add debug printout during releasing partial assigned resources
    Date
    We try to assign required+optional at first, and we only accept the result
    if all resources get allocated. Otherwise will release assigned in the
    list, and try to assign required and expand to optional.

    We have to do that to make sure any required has priority over any optional.

    When that happens, we only print out "assigned" info, that is confusing
    as it looks like same range is assigned to two peer resources at the same
    time.

    Add printout for releasing so we have whole picture in debug messages.

    Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    ---
    drivers/pci/setup-bus.c | 14 +++++++++++---
    1 file changed, 11 insertions(+), 3 deletions(-)

    diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
    index cf6f9f9..9d6a846 100644
    --- a/drivers/pci/setup-bus.c
    +++ b/drivers/pci/setup-bus.c
    @@ -526,9 +526,17 @@ static void __assign_resources_sorted(struct list_head *head,

    free_list(&local_fail_head);
    /* Release assigned resource */
    - list_for_each_entry(dev_res, head, list)
    - if (dev_res->res->parent)
    - release_resource(dev_res->res);
    + list_for_each_entry(dev_res, head, list) {
    + struct resource *res = dev_res->res;
    +
    + if (res->parent) {
    + dev_printk(KERN_DEBUG, &dev_res->dev->dev,
    + "BAR %d: released %pR\n",
    + (int)(res - &dev_res->dev->resource[0]),
    + res);
    + release_resource(res);
    + }
    + }
    /* Restore start/end/flags from saved list */
    list_for_each_entry(save_res, &save_head, list) {
    struct resource *res = save_res->res;
    --
    1.8.4.5
    \
     
     \ /
      Last update: 2016-02-25 05:01    [W:4.072 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site