Messages in this thread | | | Date | Thu, 25 Feb 2016 10:53:47 +0900 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer |
| |
On Wed, Feb 24, 2016 at 05:39:32PM +0000, Richard Fitzgerald wrote: > On 24/02/16 04:08, Mark Brown wrote:
> >I think that stuff was originally based on the way the datasheets quote > >things:
> >>- arizona_fll_dbg(fll, "FRATIO=%x(%d) OUTDIV=%x REFCLK_DIV=%x\n", > >the hex(decimal) but there is certainly very familiar from some of > >those.
> Indeed, and it was fine on the first codec. Now we've got various revisions > of the FLL with some fields having different meanings, human error started > to creep into interpreting the debug.
I'm not saying it's a bad idea to change it, just pointing out where it's likely to have come from (and the fact that the way the datasheets were writing this was always a bit weird). [unhandled content-type:application/pgp-signature] | |