lkml.org 
[lkml]   [2016]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 06/12] powerpc/module: Rework is_early_mcount_callsite()
    From
    Date

    On 25/02/16 01:28, Michael Ellerman wrote:
    > is_early_mcount_callsite() needs to detect either the two instruction or
    > the three instruction versions of the _mcount() sequence.
    >
    > But if we're running a kernel with the two instruction sequence, we need
    > to be careful not to read instruction - 2, otherwise we might fall off
    > the front of a page and cause an oops.
    >
    > While we're here convert to bool to make the return semantics clear.
    >
    > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    > ---
    > arch/powerpc/kernel/module_64.c | 30 ++++++++++++++----------------
    > 1 file changed, 14 insertions(+), 16 deletions(-)
    >
    > Squash.
    >
    >
    Do we even need to do this anymore?

    Balbir Singh.

    \
     
     \ /
      Last update: 2016-02-25 01:21    [W:3.358 / U:1.780 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site