| Date | Wed, 24 Feb 2016 20:29:32 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7) |
| |
Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu: > Hello, > > This patchset implements a new feature that collects hist entries in a > hierachical manner. That means lower-level entries belong to an > upper-level entry. The entry hierachy is built on the sort keys > given, so users can set it whatever they want. It only shows > top-level entries first, and user can expand/collapse it dynamically. > > * Changes from v6) > - pass srcline, srcfile and trace_output of hist entry properly (Jiri) > - use hist_entry__snprintf_alignment() (Jiri)
Suggestion for further improvement:
perf top --hierarchy -e sched:sched_switch -s prev_comm,prev_pid,next_comm,next_pid
Will have four levels, would be nice to have just two, perhaps expressed via:
perf top --hierarchy -e sched:sched_switch -s prev_comm+prev_pid,next_comm+next_pid
Where '+' would work as sort order separator, just like ',' but would have special meaning for --hierarchy.
What do you think?
- Arnaldo
|