lkml.org 
[lkml]   [2016]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: comedi: mite: added spaces around | and *
From
Date
On 22/02/16 23:38, Philippe Loctaux wrote:
> Added spaces around | and *, fixing 2 checkpatch checks.
>
> Signed-off-by: Philippe Loctaux <phil@philippeloctaux.com>
> ---
> drivers/staging/comedi/drivers/mite.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
[snip]
> @@ -216,7 +216,7 @@ EXPORT_SYMBOL_GPL(mite_free_ring);
> struct mite_channel *mite_request_channel_in_range(struct mite_struct *mite,
> struct
> mite_dma_descriptor_ring
> - *ring, unsigned min_channel,
> + * ring, unsigned min_channel,
> unsigned max_channel)

Actually, that one looks like a false positive by the checkpatch tool.
I'd expect no space after that '*'. checkpatch has probably got
confused by the line-break before the '*'.

It looks a bit ugly anyway. It would look better if there was a
line-break before the function name, the same as in
"drivers/staging/comedi/drivers/mite.h":

struct mite_channel *
mite_request_channel_in_range(struct mite_struct *mite,
struct mite_dma_descriptor_ring *ring,
unsigned min_channel, unsigned max_channel)

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-

\
 
 \ /
  Last update: 2016-02-23 18:01    [W:0.682 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site