Messages in this thread | | | Date | Tue, 23 Feb 2016 10:38:32 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH v2] lib/bug.c: use common WARN helper |
| |
Andrew,
Would you like to take this patch?
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
On Tue, 23 Feb 2016 09:27:40 -0600 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> The traceoff_on_warning option doesn't have any effect on s390, powerpc, > arm64, parisc, and sh because there are two different types of WARN > implementations: > > 1) The above mentioned architectures treat WARN() as a special case of a > BUG() exception. They handle warnings in report_bug() in lib/bug.c. > > 2) All other architectures just call warn_slowpath_*() directly. Their > warnings are handled in warn_slowpath_common() in kernel/panic.c. > > Support traceoff_on_warning on all architectures and prevent any future > divergence by using a single common function to emit the warning. > > Also remove the '()' from '%pS()', because the parentheses look funky: > > [ 45.607629] WARNING: at /root/warn_mod/warn_mod.c:17 .init_dummy+0x20/0x40 [warn_mod]() > > Reported-by: Chunyu Hu <chuhu@redhat.com> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> > Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com> > Acked-and-tested-by: Prarit Bhargava <prarit@redhat.com> > ---
| |