lkml.org 
[lkml]   [2016]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 130/137] Revert "xfs: clear PF_NOFREEZE for xfsaild kthread"
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dave Chinner <david@fromorbit.com>

    commit 3e85286e75224fa3f08bdad20e78c8327742634e upstream.

    This reverts commit 24ba16bb3d499c49974669cd8429c3e4138ab102 as it
    prevents machines from suspending. This regression occurs when the
    xfsaild is idle on entry to suspend, and so there s no activity to
    wake it from it's idle sleep and hence see that it is supposed to
    freeze. Hence the freezer times out waiting for it and suspend is
    cancelled.

    There is no obvious fix for this short of freezing the filesystem
    properly, so revert this change for now.

    Signed-off-by: Dave Chinner <david@fromorbit.com>
    Acked-by: Jiri Kosina <jkosina@suse.cz>
    Reviewed-by: Brian Foster <bfoster@redhat.com>
    Signed-off-by: Dave Chinner <david@fromorbit.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/xfs/xfs_trans_ail.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/fs/xfs/xfs_trans_ail.c
    +++ b/fs/xfs/xfs_trans_ail.c
    @@ -497,7 +497,6 @@ xfsaild(
    long tout = 0; /* milliseconds */

    current->flags |= PF_MEMALLOC;
    - set_freezable();

    while (!kthread_should_stop()) {
    if (tout && tout <= 20)

    \
     
     \ /
      Last update: 2016-02-24 05:41    [W:4.098 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site