lkml.org 
[lkml]   [2016]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch V2 26/28] x86/perf/intel/rapl: Convert it to a per package facility
On Mon, Feb 22, 2016 at 04:52:28PM +0100, Thomas Gleixner wrote:
> On Mon, 22 Feb 2016, Peter Zijlstra wrote:
>
> > On Mon, Feb 22, 2016 at 11:07:02AM -0000, Thomas Gleixner wrote:
> > > +static inline struct rapl_pmu *cpu_to_rapl_pmu(unsigned int cpu)
> > > +{
> > > + return rapl_pmus->pmus[topology_logical_package_id(cpu)];
> > > +}
> >
> > > @@ -370,6 +378,7 @@ static int rapl_pmu_event_init(struct pe
> > > return -EINVAL;
> > >
> > > /* must be done before validate_group */
> > > + pmu = cpu_to_rapl_pmu(event->cpu);
> > > event->cpu = pmu->cpu;
> > > event->pmu_private = pmu;
> >
> > This again looks like pmu_private is 'trivially' replacable with
> > something like:
> >
> > static inline struct rapl_pmu *event_to_rapl_pmu(struct perf_event *event)
> > {
> > return cpu_to_rapl_pmu(event->cpu);
> > }
>
> Yes, it is. But that's 3 loads versus 1 and we have that in the perf fastpath,
> so I prefer to keep the pmu_private add on.

OK, fair enough.

\
 
 \ /
  Last update: 2016-02-22 17:21    [W:0.069 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site