lkml.org 
[lkml]   [2016]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes
A couple more comments for things i just realised:

> + /*
> + * Now that all the counters are disabled, we can safely turn the PMU on,
> + * without syncing the status of the counters
> + */
> + __cci_pmu_enable(cci_pmu, CCI_CNTRS_NOSYNC);

As per my other comment, __cci_pmu_enable_nosync(cci_pmu) would be
preferable.

[...]

> + pmu_write_counter(cci_pmu,
> + (u32)local64_read(&event->hw.prev_count), i);

That cast can go.

Mark.

\
 
 \ /
  Last update: 2016-02-22 16:41    [W:0.161 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site