lkml.org 
[lkml]   [2016]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v2 10/16] clk: move checking .git_parent to __clk_core_init()
On 02/02, Masahiro Yamada wrote:
> 2016-02-02 11:39 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>:
> >
> > Right, this patch moves the check to __clk_core_init(), and it
> > will print an error and then keep going (because we lost the goto
> > out part). Once we keep going in __clk_core_init() we'll call
> > __clk_init_parent() and NULL pointer deref.
> >
>
> Ah, I missed that.
>
> We need
>
> ret = -EINVAL;
> goto out;
>
> here, I think.
>
> Shall I send the v3 for 08/16?
>
> Or, if it is too late, shall I send a fix-up patch?
>

I'll split the patch out again and squash in those two lines.
Nothing more to do. Thanks.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2016-02-02 22:01    [W:0.834 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site