Messages in this thread | | | Subject | Re: [PATCH 22/31] x86, pkeys: dump pkey from VMA in /proc/pid/smaps | From | Dave Hansen <> | Date | Tue, 2 Feb 2016 11:04:23 -0800 |
| |
On 02/02/2016 08:11 AM, Vlastimil Babka wrote: >> +void __weak arch_show_smap(struct seq_file *m, struct vm_area_struct >> *vma) >> +{ >> +} > > Is it valid that this serves also as a declaration? Or should it be also > in some header?
I guess having it in a header would make it less likely that someone screws up a definition farther down the line. But, it also seemed a wee bit of overkill for a single user.
I'm happy to send a follow-on patch to add it to a header somewhere.
| |