lkml.org 
[lkml]   [2016]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 100/136] ALSA: control: Avoid kernel warnings from tlv ioctl with numid 0
    Date
    3.13.11-ckt34 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit c0bcdbdff3ff73a54161fca3cb8b6cdbd0bb8762 upstream.

    When a TLV ioctl with numid zero is handled, the driver may spew a
    kernel warning with a stack trace at each call. The check was
    intended obviously only for a kernel driver, but not for a user
    interaction. Let's fix it.

    This was spotted by syzkaller fuzzer.

    Reported-by: Dmitry Vyukov <dvyukov@google.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    sound/core/control.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/sound/core/control.c b/sound/core/control.c
    index f2082a3..3fcead6 100644
    --- a/sound/core/control.c
    +++ b/sound/core/control.c
    @@ -1325,6 +1325,8 @@ static int snd_ctl_tlv_ioctl(struct snd_ctl_file *file,
    return -EFAULT;
    if (tlv.length < sizeof(unsigned int) * 2)
    return -EINVAL;
    + if (!tlv.numid)
    + return -EINVAL;
    down_read(&card->controls_rwsem);
    kctl = snd_ctl_find_numid(card, tlv.numid);
    if (kctl == NULL) {
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-02-02 20:01    [W:4.050 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site